Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@isra17
Copy link
Contributor

isra17 commented Oct 23, 2019

@aviau if you want to do a quick review. Most of the content is in storage.py, test_storage.py was mostly taken from Huey and is not worth reviewing.

@aviau

This comment has been minimized.

Copy link
Member

aviau commented Oct 24, 2019

Could we setup travis? And run the tests?

Example: https://github.com/Flared/python-purple/blob/master/.travis.yml

@isra17

This comment has been minimized.

Copy link
Contributor Author

isra17 commented Oct 24, 2019

Another PR? :) Can confirm I ran the test locally for now

@aviau

This comment has been minimized.

Copy link
Member

aviau commented Oct 24, 2019

Sure, as long as its not forgotten ;)

image

@isra17 isra17 merged commit ffbc01e into master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.