Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to execute method parameter statement #1

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@fxleblanc
Copy link

commented Oct 3, 2019

No description provided.

@@ -97,7 +97,7 @@ class Engine(Connectable, log.Identified):
def begin(self, close_with_result: bool = ...): ...
def transaction(self, callable_, *args, **kwargs): ...
def run_callable(self, callable_, *args, **kwargs): ...
def execute(self, statement, *multiparams, **params): ...
def execute(self, statement: TextClause, *multiparams, **params): ...

This comment has been minimized.

@fxleblanc fxleblanc force-pushed the add-execute-type branch from 3700f64 to b6acba8 Oct 3, 2019
@fxleblanc fxleblanc force-pushed the add-execute-type branch from b6acba8 to f65c7e5 Oct 3, 2019
@fxleblanc

This comment has been minimized.

Copy link
Author

commented Oct 3, 2019

@isra17 looks good to merge?

@isra17

This comment has been minimized.

Copy link

commented Oct 3, 2019

lgtm, can you change target to master-fork?

@fxleblanc fxleblanc changed the base branch from master to master-fork Oct 3, 2019
@fxleblanc fxleblanc merged commit 67820da into master-fork Oct 3, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.