Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DarkSky API replacement #113

Merged
merged 7 commits into from May 14, 2021
Merged

DarkSky API replacement #113

merged 7 commits into from May 14, 2021

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented May 3, 2021

closes #3

@nhoening
Copy link
Contributor

@nhoening nhoening commented May 4, 2021

To compare the new OWM forecasts (data source 76, shown left) with the old DS forecasts (data source 55, shown right):

Screenshot from 2021-05-04 12-09-44

They disagree on the cloud coverage for a few hours but otherwise I believe this is fine.

@nhoening nhoening marked this pull request as ready for review May 4, 2021
@nhoening nhoening requested a review from Flix6x May 4, 2021
@nhoening nhoening added the Data label May 4, 2021
@nhoening nhoening self-assigned this May 5, 2021
Copy link
Contributor

@Flix6x Flix6x left a comment

I reviewed the code (minor requests only I believe). I did not test it. Let me know how to best do that if you want me to.

documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/data/scripts/grid_weather.py Show resolved Hide resolved
flexmeasures/data/scripts/grid_weather.py Outdated Show resolved Hide resolved
@nhoening
Copy link
Contributor

@nhoening nhoening commented May 6, 2021

@Flix6x Another comparison, now the temperature readings from our call to OWM, and a screenshot from the OWM website. Here we want to see if we catch their data at the right time. In our database we see UTC times, which are two hours behind current Amsterdam time. Looks to me like the data is the correct data at the correct time.

Screenshot from 2021-05-06 17-41-28
Screenshot from 2021-05-06 17-40-55

@nhoening nhoening requested a review from Flix6x May 7, 2021
@nhoening nhoening added this to the 0.5.0 milestone May 7, 2021
Flix6x
Flix6x approved these changes May 13, 2021
Copy link
Contributor

@Flix6x Flix6x left a comment

Only minor comments.

documentation/changelog.rst Outdated Show resolved Hide resolved
documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/data/scripts/grid_weather.py Outdated Show resolved Hide resolved
flexmeasures/data/scripts/grid_weather.py Outdated Show resolved Hide resolved
flexmeasures/data/scripts/grid_weather.py Outdated Show resolved Hide resolved
@nhoening nhoening merged commit 1203621 into main May 14, 2021
2 checks passed
@nhoening nhoening deleted the issue-3-DarkSky_API_replacement branch May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants