Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time_utils.get_recent_clock_time_window() function #135

Merged
merged 3 commits into from May 20, 2021

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented May 18, 2021

No description provided.

@nhoening nhoening requested a review from Flix6x May 18, 2021
Flix6x
Flix6x approved these changes May 19, 2021
Copy link
Contributor

@Flix6x Flix6x left a comment

Just add some more test cases. I think the code is good.

flexmeasures/utils/tests/test_time_utils.py Show resolved Hide resolved
assert end == exp_end


def test_recent_clocktime_window_invalid_window():
Copy link
Contributor

@Flix6x Flix6x May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

120 minutes should also fail, right?
What about 0?

@nhoening nhoening merged commit af342e2 into main May 20, 2021
1 check passed
@nhoening nhoening deleted the add-recent_clock_time-util-function branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants