Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timely-beliefs tooling to create forecast model specs #154

Merged
merged 20 commits into from Nov 1, 2021
Merged

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jul 19, 2021

This PR introduces TBSeriesSpecs (subclassed from SeriesSpecs) that makes use of the collect functionality introduced earlier in FlexMeasures. We need such timely-beliefs tooling to ensure our beliefs data is properly mapped to a time series data structure that ML models can work with (i.e. feature frames). Currently, the collect functionality makes sure that the regressor data is deterministic and single-sourced.

Also introduces the possibility to set the desired resolution of forecasts, plus some minor refactoring.

@Flix6x Flix6x self-assigned this Jul 19, 2021
@Flix6x Flix6x added this to In progress in Data model based on timely beliefs via automation Jul 19, 2021
@Flix6x Flix6x changed the title Use timely-beliefs tooling for creating forecast model specs Use timely-beliefs tooling to create forecast model specs Jul 20, 2021
@Flix6x Flix6x marked this pull request as ready for review Jul 20, 2021
@Flix6x Flix6x requested a review from nhoening Jul 20, 2021
Copy link
Contributor

@nhoening nhoening left a comment

I approve of the logic (looks very nice), but have some wished about documentation and an investigation into a parameter.

flexmeasures/data/models/forecasting/model_spec_factory.py Outdated Show resolved Hide resolved
flexmeasures/data/models/forecasting/model_spec_factory.py Outdated Show resolved Hide resolved
flexmeasures/data/scripts/cli_tasks/data_add.py Outdated Show resolved Hide resolved
flexmeasures/data/scripts/data_gen.py Show resolved Hide resolved
flexmeasures/data/services/forecasting.py Show resolved Hide resolved
flexmeasures/data/services/forecasting.py Outdated Show resolved Hide resolved
Data model based on timely beliefs automation moved this from In progress to In review Jul 21, 2021
@nhoening
Copy link
Contributor

@nhoening nhoening commented Jul 22, 2021

Does this deserve a changelog entry? I think it might. It would also force you to formulate the benefit of this PR from a higher perspective. I believe that with the level of timely beliefs integration we already have, this PR is necessary to achieve forecasting, or some part of that functionality. But I think you know this more precisely.

@nhoening
Copy link
Contributor

@nhoening nhoening commented Jul 24, 2021

One more thought: can you check if the tutorial on creating forecasts would require adaptations after this PR?

@Flix6x Flix6x merged commit c4d456a into main Nov 1, 2021
2 checks passed
Data model based on timely beliefs automation moved this from In review to Done Nov 1, 2021
@Flix6x Flix6x deleted the tb-model-specs branch Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants