Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less custom logfile location, documentation of logging in dev docs #196

Merged
merged 2 commits into from Sep 28, 2021

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Sep 28, 2021

No description provided.

@nhoening nhoening added this to the 0.7.0 milestone Sep 28, 2021
@nhoening nhoening requested a review from Flix6x Sep 28, 2021
Flix6x
Flix6x approved these changes Sep 28, 2021
Copy link
Contributor

@Flix6x Flix6x left a comment

I understood that the config settings can't be used to set a custom log path, because the logger gets loaded first and those settings only get loaded with the app afterwards. I just had the idea of allowing for a custom log path via an ENV variable, although that does dilute the idea of having all config settings coming from one designated place. For your consideration...

@nhoening
Copy link
Contributor Author

@nhoening nhoening commented Sep 28, 2021

Okay, let's keep that idea in mind. I believe this might be the simplest way which works for most people. Many web-apps (also on PA) define a working directory, so I hope this is where the log file ends up most of the time.

@nhoening nhoening merged commit e42fa6e into main Sep 28, 2021
2 checks passed
@nhoening nhoening deleted the logging-improvements branch Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants