Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable plugin list to be an app creation param, useful for plugin tests #220

Merged
merged 7 commits into from Oct 25, 2021

Conversation

@nhoening
Copy link
Contributor

@nhoening nhoening commented Oct 22, 2021

Small addition, which makes it easier for plugin authors.

Also some smaller refactoring.

@nhoening nhoening requested a review from Flix6x Oct 22, 2021
@nhoening
Copy link
Contributor Author

@nhoening nhoening commented Oct 22, 2021

Not sure this needs a changelog entry. Seems too small.

Copy link
Contributor

@Flix6x Flix6x left a comment

I guess I'm missing a documentation edit that shows how plugin authors are affected by this change.

@nhoening nhoening requested a review from Flix6x Oct 24, 2021
Flix6x
Flix6x approved these changes Oct 24, 2021
Copy link
Contributor

@Flix6x Flix6x left a comment

Thanks for addressing my comment. Now I do think it warrants a changelog entry, under new features, seeing as this is what makes plugin tests possible.

@nhoening nhoening requested a review from Flix6x Oct 24, 2021
Flix6x
Flix6x approved these changes Oct 25, 2021
@nhoening nhoening merged commit 3a3506f into main Oct 25, 2021
2 checks passed
@nhoening nhoening deleted the plugin-as-app-creation-param-for-plugin-tests branch Oct 25, 2021
@Flix6x Flix6x added this to the 0.7.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants