Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart theme #221

Merged
merged 9 commits into from Nov 1, 2021
Merged

Add chart theme #221

merged 9 commits into from Nov 1, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Oct 23, 2021

Starting a place for FlexMeasures' default chart styling.

@Flix6x Flix6x requested a review from nhoening Oct 23, 2021
@Flix6x Flix6x self-assigned this Oct 23, 2021
Copy link
Contributor

@nhoening nhoening left a comment

Is this the only file or are there some missing?

@Flix6x
Copy link
Contributor Author

@Flix6x Flix6x commented Oct 24, 2021

Just the one.

@nhoening
Copy link
Contributor

@nhoening nhoening commented Oct 24, 2021

To be used from plugins, I assume?

@Flix6x Flix6x changed the title Add tooltip theme Add chart theme Oct 26, 2021
@Flix6x
Copy link
Contributor Author

@Flix6x Flix6x commented Oct 26, 2021

Okay, I made this PR a little more interesting now. You made me realise there were already 2 places in FlexMeasures where a default theme should be used. One of them (sensors/<id>/chart) now has the option to ask for the chart in one of the supported custom vega-lite themes.

To test (replacing the <id> and datetime to your liking):

/sensors/<id>/chart/?event_starts_after=2021-10-25T00:00:00Z&chart_theme=fivethirtyeight

@Flix6x Flix6x requested a review from nhoening Oct 26, 2021
Copy link
Contributor

@nhoening nhoening left a comment

Very nice that we can do this.

@Flix6x Flix6x merged commit 7eceabc into main Nov 1, 2021
2 checks passed
@Flix6x Flix6x deleted the flexmeasures-chart-styling branch Nov 1, 2021
@Flix6x Flix6x added this to the 0.8.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants