Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get chart #223

Merged
merged 3 commits into from Oct 26, 2021
Merged

Fix get chart #223

merged 3 commits into from Oct 26, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Oct 26, 2021

The sensors/<id>/chart view had been broken, which I hadn't picked up on before because:

  1. It wasn't automatically tested.
  2. I myself prefer using the sensors/<id> view, which is nicer because it is interactive (i.e. has a calendar).

I also thought about creating test_sensor_crud.py, but I think it would need mock API responses. You did this previously in test_asset_crud.py, but I find it hard to replicate. Maybe you could help me along?

@Flix6x Flix6x added bug UI labels Oct 26, 2021
@Flix6x Flix6x requested a review from nhoening Oct 26, 2021
@Flix6x Flix6x self-assigned this Oct 26, 2021
@nhoening
Copy link
Contributor

@nhoening nhoening commented Oct 26, 2021

Can we realistically get this into 0.7.0 which I plan to get out today?

We can split the bugfix from the tests.

Copy link
Contributor

@nhoening nhoening left a comment

I have an auth question.

flexmeasures/ui/views/sensors.py Show resolved Hide resolved
@Flix6x
Copy link
Contributor Author

@Flix6x Flix6x commented Oct 26, 2021

Splitting the work on the to-be-made test from the present fix is fine for me.

Copy link
Contributor

@nhoening nhoening left a comment

Please make a new ticket for the tests.

@Flix6x Flix6x merged commit 8a5089e into main Oct 26, 2021
2 checks passed
@Flix6x Flix6x deleted the fix-get-chart branch Oct 26, 2021
@nhoening nhoening added this to the 0.7.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants