Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check plugin settings #230

Merged
merged 9 commits into from Nov 10, 2021
Merged

Check plugin settings #230

merged 9 commits into from Nov 10, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Nov 3, 2021

Based on work in our E-mission plugin.

@Flix6x Flix6x self-assigned this Nov 3, 2021
@nhoening
Copy link
Contributor

@nhoening nhoening commented Nov 3, 2021

I guess it's a good time to start a plugin_utile.py module, note that we have two functions dealing with plugins.

documentation/dev/plugins.rst Outdated Show resolved Hide resolved
flexmeasures/utils/app_utils.py Outdated Show resolved Hide resolved
@Flix6x Flix6x requested a review from nhoening Nov 3, 2021
documentation/dev/plugins.rst Outdated Show resolved Hide resolved
documentation/dev/plugins.rst Outdated Show resolved Hide resolved
flexmeasures/utils/plugin_utils.py Outdated Show resolved Hide resolved
@Flix6x Flix6x requested a review from nhoening Nov 9, 2021
Copy link
Contributor

@nhoening nhoening left a comment

Looks okay. Only smaller items.

flexmeasures/utils/plugin_utils.py Outdated Show resolved Hide resolved
flexmeasures/utils/plugin_utils.py Outdated Show resolved Hide resolved
flexmeasures/utils/plugin_utils.py Show resolved Hide resolved
flexmeasures/utils/plugin_utils.py Show resolved Hide resolved
@Flix6x Flix6x merged commit 0db7979 into main Nov 10, 2021
2 checks passed
@Flix6x Flix6x deleted the check-plugin-settings branch Nov 10, 2021
@Flix6x Flix6x added this to the 0.8.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants