Fix device message to stop confusing multiple schedules #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhoening
requested changes
Nov 6, 2021
I believe this would be great to have tested. Is that quite difficult?
|
The subquery is timely-beliefs functionality modified here to fit our old data model. It is tested in timely-beliefs (in |
nhoening
approved these changes
Nov 6, 2021
Flix6x
added a commit
that referenced
this issue
Nov 8, 2021
…ules (#231) Fixed the *getDeviceMessage* endpoint for cases in which there are multiple schedules available, by returning only the most recent one. * Query for most recent schedule only * Fix subquery in get_device_message * One more fix of subquery in get_device_message * Add inline comment * Add todo for moving to the new data model * Changelog entry * API changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.