Issue 29 better visibility of map icons using markers - #30
Merged
Flix6x merged 6 commits intoFeb 22, 2021
Merged
Conversation
Overlay map icons on empty marker.
nhoening
requested changes
Feb 18, 2021
nhoening
left a comment
nhoening
left a comment
Member
There was a problem hiding this comment.
Looks really a bit better now, congrats. The only thing for me is that the tooltip that shows when clicking on the asset is not 100% visible anymore ― the upper bit is not within the map anymore.
nhoening
approved these changes
Feb 19, 2021
Member
Author
|
I'm leaving this open a little while longer still, because I want to check the other two templates in which we use maps: |
Flix6x
deleted the
issue-29-Better_visibility_of_map_icons_using_markers
branch
February 22, 2021 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some map styling: I put map icons on top of markers and added a hover tooltip, too.
Closes #29.