Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first working version of a charts/power view; #39

Merged
merged 13 commits into from Feb 25, 2021

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Feb 21, 2021

Also getting yet more experience with marshmallow:

  • move Duration definition to a full marshmallow field definition
  • describe the whole request of an endpoint with marshmallow (could be documented with ApiSpec now)

TODO:

  • the new field representation breaks some tests, needs to be fixed
  • the endpoint should be GET, and specs should come in via url params
  • get CORS (cross-origin) configuration in place
  • support individual traces
  • I have an HMTL page I use for testing (but I also document in the endpoint how to do that). The plot is very wide, and I can't find in Bokeh docs how to change that.

…nition to a full marshmallow field definition
@nhoening nhoening self-assigned this Feb 21, 2021
@nhoening nhoening marked this pull request as draft Feb 21, 2021
@nhoening nhoening requested a review from Flix6x Feb 21, 2021
flexmeasures/api/common/schemas.py Outdated Show resolved Hide resolved
flexmeasures/api/common/schemas.py Outdated Show resolved Hide resolved
flexmeasures/ui/__init__.py Outdated Show resolved Hide resolved
flexmeasures/ui/views/analytics.py Outdated Show resolved Hide resolved
flexmeasures/ui/views/analytics.py Show resolved Hide resolved
flexmeasures/ui/views/charts.py Show resolved Hide resolved
flexmeasures/ui/views/charts.py Outdated Show resolved Hide resolved
flexmeasures/ui/views/charts.py Outdated Show resolved Hide resolved
flexmeasures/ui/views/charts.py Outdated Show resolved Hide resolved
nhoening and others added 3 commits Feb 22, 2021
@nhoening nhoening marked this pull request as ready for review Feb 24, 2021
Flix6x
Flix6x approved these changes Feb 25, 2021
flexmeasures/ui/views/charts.py Outdated Show resolved Hide resolved
flexmeasures/utils/config_defaults.py Outdated Show resolved Hide resolved
@nhoening nhoening merged commit e9b5844 into main Feb 25, 2021
2 checks passed
@nhoening nhoening deleted the issue-38-Support_power_figures_through_the_API branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants