Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose redis worker #455

Merged
merged 18 commits into from
Jul 15, 2022
Merged

Docker compose redis worker #455

merged 18 commits into from
Jul 15, 2022

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Jul 5, 2022

Closes #418

Also adds more documentation and lets us add schedules as a job in the CLI.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…o the queue (--as-jobs)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…er parts, e.g. update and correct usage of CLI forecasting, redis as independent page under hosting

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x July 5, 2022 20:51
@nhoening nhoening marked this pull request as ready for review July 5, 2022 20:51
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…/flexmeasures into docker-compose-redis-worker
@coveralls
Copy link
Collaborator

coveralls commented Jul 5, 2022

Pull Request Test Coverage Report for Build 2679470627

  • 11 of 51 (21.57%) changed or added relevant lines in 3 files are covered.
  • 252 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.9%) to 67.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/utils/config_utils.py 0 1 0.0%
flexmeasures/cli/data_add.py 2 14 14.29%
flexmeasures/cli/jobs.py 9 36 25.0%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/models/data_sources.py 1 56.16%
flexmeasures/data/schemas/utils.py 1 81.25%
flexmeasures/utils/config_utils.py 1 31.3%
flexmeasures/cli/jobs.py 2 27.66%
flexmeasures/api/v3_0/assets.py 3 96.15%
flexmeasures/data/services/sensors.py 7 26.09%
flexmeasures/api/v3_0/sensors.py 18 70.1%
flexmeasures/api/dev/sensors.py 20 61.64%
flexmeasures/data/models/charts/defaults.py 21 52.04%
flexmeasures/data/models/charts/belief_charts.py 27 13.33%
Totals Coverage Status
Change from base Build 2638960995: -0.9%
Covered Lines: 7150
Relevant Lines: 10025

💛 - Coveralls

@nhoening nhoening added this to the 0.11.0 milestone Jul 6, 2022
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have the asynchronous stuff dockerized, too now. Here are my initial comments. I still need to test.

documentation/dev/docker-compose.rst Show resolved Hide resolved
documentation/dev/docker-compose.rst Outdated Show resolved Hide resolved
documentation/host/queues.rst Outdated Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Outdated Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Outdated Show resolved Hide resolved
flexmeasures/cli/data_add.py Outdated Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Outdated Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Outdated Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Show resolved Hide resolved
documentation/tut/forecasting_scheduling.rst Show resolved Hide resolved
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…ted suffix number if taken

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x July 12, 2022 11:15
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only remaining comment is about showing and clearing the failed queue. If this is holding the PR back, feel free to revert the applicable commits and to open a separate PR for that.

flexmeasures/cli/jobs.py Outdated Show resolved Hide resolved
… ordering of CLI args

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x July 15, 2022 08:22
flexmeasures/cli/jobs.py Outdated Show resolved Hide resolved
flexmeasures/cli/jobs.py Outdated Show resolved Hide resolved
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit d428472 into main Jul 15, 2022
@nhoening nhoening deleted the docker-compose-redis-worker branch July 15, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Redis and a worker to Docker-Compose
3 participants