-
Notifications
You must be signed in to change notification settings - Fork 38
Issue 460 remember selected calendar period within session #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 460 remember selected calendar period within session #467
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Pull Request Test Coverage Report for Build 2723799853
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First question: why not reuse start_time
and end_time
?
(Can we retire them, as we used them on analytics and portfolio views?)
I didn't really want to involve / touch the code that re-interprets those datetimes in the server's ttimezone and stores them as |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
I chose to set the session data with the
/chart
instead of the/chart_data
endpoints (for sensors and assets), because the former endpoint can be called without the need to call the latter (usinginclude_data=true
). Right now both the sensor and asset page are calling the/chart
endpoint with each date pick.Closes #460.