Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure vega view is embedded in page before attempting to change its dataset #472


Copy link

@Flix6x Flix6x commented Aug 8, 2022

Asynchronous reloading of a chart's dataset relies on that chart already having been embedded. This fix makes sure the vegaView variable is set up before any of the data fetching promises's then blocks try to load the view with data.

Closes #468.

…ts dataset

Signed-off-by: F.N. Claessen <>
@Flix6x Flix6x added this to the 0.11.0 milestone Aug 8, 2022
@Flix6x Flix6x self-assigned this Aug 8, 2022
Signed-off-by: F.N. Claessen <>
Copy link

coveralls commented Aug 8, 2022

Pull Request Test Coverage Report for Build 2818289457

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.577%

Totals Coverage Status
Change from base Build 2754317583: 0.0%
Covered Lines: 7207
Relevant Lines: 10091

💛 - Coveralls

@Flix6x Flix6x requested a review from nhoening August 8, 2022 13:32
Copy link

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change, and I cannot reproduce the error locally. Great job!

@Flix6x Flix6x merged commit 97484c0 into main Aug 9, 2022
@Flix6x Flix6x deleted the Issue-468_Asset_and_sensor_pages_sometimes_showing_no_data_on_page_load branch August 9, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Asset and sensor pages sometimes showing no data on page load
3 participants