Merged
Conversation
…duler rather than by the /schedules/trigger/ endpoint Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…to SoC units Signed-off-by: F.N. Claessen <felix@seita.nl>
…at we set up the constraints for an infeasible problem; let's remedy that Signed-off-by: F.N. Claessen <felix@seita.nl>
…unit Signed-off-by: F.N. Claessen <felix@seita.nl>
… to do Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Contributor
Author
Collaborator
Pull Request Test Coverage Report for Build 3805594227
💛 - Coveralls |
Contributor
nhoening
approved these changes
Dec 29, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following bugs:
test_trigger_and_get_schedulewas not checking for soc-targets sent in the deprecated soc-targets fieldtest_trigger_and_get_schedulewas not taking into account efficiency losses when checking soc-targetstest_trigger_and_get_schedulewas not checking for soc-targets sent within the flex-model fieldtest_trigger_and_get_schedulewas assuming wrong units for the soc-max and soc-targets fields, thereby creating an unsolvable scheduling problem**kwargsvariable, and not moved over to become part of the flex-model field