Skip to content

400 support passing a custom duration to /schedules/trigger [POST]#568

Merged
Flix6x merged 21 commits intomainfrom
400-support-passing-a-custom-duration-to-schedulestrigger-post
Dec 30, 2022
Merged

400 support passing a custom duration to /schedules/trigger [POST]#568
Flix6x merged 21 commits intomainfrom
400-support-passing-a-custom-duration-to-schedulestrigger-post

Conversation

@Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 30, 2022

  • Support passing a custom duration to /schedules/trigger [POST].
  • Allow SoC targets to exceed the default planning horizon, dynamically extending the planning window.
  • Introduce a new config setting: FLEXMEASURES_MAX_PLANNING_HORIZON.
  • Do not allow SoC targets to exceed the max planning horizon.

Flix6x added 16 commits December 29, 2022 20:53
@Flix6x
Support passing a custom duration to /schedules/trigger/ [POST]
30f70c0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: load_default becomes class method
4f7b546 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge branch 'main' into 400-support-passing-a-custom-duration-to-sch…
f7b9fec 
…edulestrigger-post

Signed-off-by: F.N. Claessen <felix@seita.nl>

# Conflicts:
#	flexmeasures/api/v3_0/tests/test_sensor_schedules.py
@Flix6x
Amend length of schedule given the duration in the trigger message
2f32729 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Possibly expand duration given future-most target
7271e7b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Move extension of planning window to after deserialization of SoC tar…
d8dc06e 
…gets

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Test extension of planning window to accommodate targets
13c8790 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Limit extension of planning window by introducing the FLEXMEASURES_MA…
fc0acf7 
…X_PLANNING_HORIZON config setting

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add missing API upgrade instruction
4e62af0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Update documentation, incl. API changelog
1b92c24 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
typo
2715cf3 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix type annotation
f240f9b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Test failing on target datetimes exceeding max planning horizon
32ef070 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Rewrite validator to be specific for soc-targets field
00c280b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Clarify validation of target datetimes
b1b97b9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
black and mypy
8231441 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening December 30, 2022 11:14
@Flix6x Flix6x self-assigned this Dec 30, 2022
@Flix6x Flix6x linked an issue Dec 30, 2022 that may be closed by this pull request
Support passing a custom duration to /schedules/trigger [POST] #400
Closed
Flix6x
Flix6x commented Dec 30, 2022
View reviewed changes
@Flix6x
Fix tests
898ff0b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Dec 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3807033946

  • 38 of 40 (95.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 65.65%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/models/planning/storage.py 11 12 91.67%
flexmeasures/data/schemas/times.py 4 5 80.0%
Totals Coverage Status
Change from base Build 3805617287: 0.1%
Covered Lines: 6868
Relevant Lines: 9834
💛 - Coveralls

nhoening
nhoening approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very clean, great work!

@Flix6x
Add todo
aba78c4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
API changelog entry
9a894f8 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Changelog entry
ebceee4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Extra changelog entry for new config setting
f30954e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit da007ed into main Dec 30, 2022
@Flix6x Flix6x deleted the 400-support-passing-a-custom-duration-to-schedulestrigger-post branch December 30, 2022 13:12
@Flix6x Flix6x mentioned this pull request Jan 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels

API Scheduling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support passing a custom duration to /schedules/trigger [POST]

3 participants

@Flix6x @coveralls @nhoening

Comments