Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix premature flex context deserialization #593

Merged
merged 5 commits into from Feb 27, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Feb 27, 2023

Since 0.12, deserialization of the flex-context should no longer be done by the API endpoint, but rather by the Scheduler.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.12.3 milestone Feb 27, 2023
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review February 27, 2023 11:24
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2023

Pull Request Test Coverage Report for Build 4281960623

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.362%

Totals Coverage Status
Change from base Build 4093757766: 0.0%
Covered Lines: 6847
Relevant Lines: 9835

💛 - Coveralls

@Flix6x Flix6x merged commit c02469a into main Feb 27, 2023
5 checks passed
@Flix6x Flix6x deleted the fix-premature-flex-context-deserialization branch February 27, 2023 13:00
Flix6x added a commit that referenced this pull request Feb 28, 2023
* Test flex-context deserialization

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Fix flex-context deserialization

Signed-off-by: F.N. Claessen <felix@seita.nl>

* black

Signed-off-by: F.N. Claessen <felix@seita.nl>

* flake8

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entries

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Scheduling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants