Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count of owned assets in user listing page is zero, even if they own assets #64

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Mar 19, 2021

closes #63

@nhoening nhoening marked this pull request as ready for review Mar 19, 2021
@nhoening nhoening requested a review from Flix6x Mar 19, 2021
@@ -67,7 +67,7 @@ <h2> Account overview for {{ user.username }} </h2>
Assets owned
</td>
<td>
<a href="/assets/owned_by/{{ user.id }}">{{ user.assets | length }}</a>
Copy link
Contributor

@Flix6x Flix6x Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why did this not work?

Copy link
Contributor

@nhoening nhoening Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our UI calls our API, but the API is not returning the assets of the user like SQLAlchemy automatically does (with a second query). Our API returns a JSON structure, and whoever wants the assets can make a second call.

Flix6x
Flix6x approved these changes Mar 19, 2021
@nhoening nhoening merged commit 679ea53 into main Mar 21, 2021
2 checks passed
@Flix6x Flix6x deleted the issue-63-Count_of_owned_assets_in_user_listing_page_is_zero_even_if_they_own_assets branch Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants