Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6 entity address scheme improvements 2 #81

Merged
merged 27 commits into from May 28, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 2, 2021

closes #6

Copy link
Contributor Author

@Flix6x Flix6x left a comment

For your convenience, I left some comments while reviewing my own work.

flexmeasures/api/common/utils/api_utils.py Show resolved Hide resolved
flexmeasures/api/common/schemas/sensors.py Show resolved Hide resolved
flexmeasures/api/common/utils/validators.py Show resolved Hide resolved
flexmeasures/api/v1_1/implementations.py Show resolved Hide resolved
flexmeasures/api/v1_1/tests/conftest.py Outdated Show resolved Hide resolved
flexmeasures/data/models/time_series.py Show resolved Hide resolved
flexmeasures/utils/entity_address_utils.py Show resolved Hide resolved
flexmeasures/utils/entity_address_utils.py Show resolved Hide resolved
@Flix6x Flix6x marked this pull request as ready for review Apr 3, 2021
@Flix6x Flix6x requested a review from nhoening Apr 3, 2021
Copy link
Contributor

@nhoening nhoening left a comment

Great stuff. Also, a lot of work. I do feel bad asking for it, but some effort on the documentation side seems in order within this PR so that it reflects the level of attention the code gives to entity addresses.

I believe we can make a new page in the documentation without writing too much new content, see one of my comments.

flexmeasures/api/common/schemas/sensors.py Show resolved Hide resolved
flexmeasures/utils/entity_address_utils.py Outdated Show resolved Hide resolved
flexmeasures/api/common/utils/validators.py Show resolved Hide resolved
flexmeasures/utils/entity_address_utils.py Show resolved Hide resolved
flexmeasures/utils/entity_address_utils.py Show resolved Hide resolved
flexmeasures/utils/entity_address_utils.py Outdated Show resolved Hide resolved
documentation/api/introduction.rst Outdated Show resolved Hide resolved
flexmeasures/api/v2_0/tests/utils.py Outdated Show resolved Hide resolved
flexmeasures/api/v2_0/tests/utils.py Show resolved Hide resolved
@Flix6x Flix6x added this to the 0.5.0 milestone May 21, 2021
@nhoening
Copy link
Contributor

@nhoening nhoening commented May 21, 2021

Copy link
Contributor Author

@Flix6x Flix6x left a comment

  • The main changelog could use an entry, I guess under Infrastructure/Support.
  • The API changelog also needs some entries, something along the line of:
    • Updated all entity addresses in documentation according to the fm0 scheme, preserving backwards compatibility
    • Introduced the fm1 scheme for entity addresses for connections, markets, weather sensors and sensors

documentation/api/introduction.rst Outdated Show resolved Hide resolved
documentation/api/introduction.rst Outdated Show resolved Hide resolved
@Flix6x
Copy link
Contributor Author

@Flix6x Flix6x commented May 27, 2021

While you're in the API changelog, could you please date v1.3.9 | 2021-04-XX to v1.3.9 | 2021-04-21?

@nhoening nhoening merged commit 927aba9 into main May 28, 2021
1 check passed
@nhoening nhoening deleted the issue-6-Entity_address_scheme_improvements_2 branch May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants