Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wrong format in asset editing leads to unhelpful error message #93

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Apr 8, 2021

closes #89

We improve the general ability of the asset edit form to display the invalid user input back to the user, so they can change their data.

@nhoening nhoening marked this pull request as ready for review Apr 8, 2021
@nhoening nhoening requested a review from Flix6x Apr 8, 2021
Flix6x
Flix6x approved these changes Apr 11, 2021
Copy link
Contributor

@Flix6x Flix6x left a comment

Only one remark.

asset_form=asset_form,
asset=asset_info,
Copy link
Contributor

@Flix6x Flix6x Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not hand over the asset object itself to Jinja? Then it would be easier to adjust asset.html (e.g. show a new asset property) without the need to also explicitly add it to the asset_info dict.

Copy link
Contributor

@nhoening nhoening Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task at hand here is to give the form data to Jinja, so that invalid data can be properly displayed (for the user to be able to adjust it). The asset object is fresh from the database, not what the user just entered.

@nhoening nhoening changed the title Using wrong format in asset editing leads to unehlpful error message Using wrong format in asset editing leads to unhelpful error message Apr 11, 2021
@nhoening nhoening merged commit ad6fa3f into main Apr 11, 2021
2 checks passed
@nhoening nhoening deleted the issue-89-Using_wrong_format_in_asset_editing_leads_to_unehlpful_error_message branch Apr 11, 2021
@nhoening nhoening added this to the 0.4.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants