Add option to allow empty links in html plugin #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvium
reviewed
Mar 9, 2018
| @@ -44,6 +44,7 @@ def validator(self): | |||
| advanced.accept('text', key='password') | |||
| advanced.accept('text', key='dump') | |||
| advanced.accept('text', key='title_from') | |||
| advanced.accept('boolean', key='allow_empty_links') | |||
There was a problem hiding this comment.
I'm not sure the name properly conveys the meaning
There was a problem hiding this comment.
I'm open to any suggestion for a better name... Maybe allow_empty_content?
|
Any chance this change be merged? |
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Some links are sometimes empty but have a CSS style that make them visible (typically an icon) but html plugin ignores them
Detailed changes:
allow_empty_linksoption in html pluginallow_empty_linksis False by default for backward compatibility.