Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] pending list batch operation and deletion endpoint #2535

Merged
merged 5 commits into from Dec 17, 2019

Conversation

kristenmills
Copy link
Member

@kristenmills kristenmills commented Dec 17, 2019

Motivation for changes:

I'm adding some bulk operation features to webui (Flexget/webui#54) so this seemed better than making a lot of requests. Eventually I want to just make graphQL or gRPC endpoints for webui to use and these batch operations will be cleaner but that's a later activity.

Detailed changes:

  • Add new endpoint PUT /pending_list/{list_id}/entries/batch for bulk approving, rejecting pending list entries
  • Add new endpoint DELETE /pending_list/{list_id}/entries/batch for bulk removing removing pending list entries

@kristenmills kristenmills changed the title Pending list batch Add] pending list batch operation endpoint Dec 17, 2019
@kristenmills kristenmills changed the title Add] pending list batch operation endpoint [Add] pending list batch operation endpoint Dec 17, 2019
flexget/components/managed_lists/lists/pending_list/api.py Outdated Show resolved Hide resolved
flexget/components/managed_lists/lists/pending_list/api.py Outdated Show resolved Hide resolved
flexget/tests/api_tests/test_pending_list_api.py Outdated Show resolved Hide resolved
flexget/tests/api_tests/test_pending_list_api.py Outdated Show resolved Hide resolved
flexget/tests/api_tests/test_pending_list_api.py Outdated Show resolved Hide resolved
flexget/components/managed_lists/lists/pending_list/api.py Outdated Show resolved Hide resolved
flexget/components/managed_lists/lists/pending_list/api.py Outdated Show resolved Hide resolved
Copy link
Member

@paranoidi paranoidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restful idioms

@kristenmills kristenmills changed the title [Add] pending list batch operation endpoint [Add] pending list batch operation and deletion endpoint Dec 17, 2019
Copy link
Member

@liiight liiight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flexget/tests/api_tests/test_pending_list_api.py Outdated Show resolved Hide resolved
@kristenmills kristenmills dismissed paranoidi’s stale review December 17, 2019 18:24

we talked about it in slack

@kristenmills kristenmills merged commit cec873f into develop Dec 17, 2019
@kristenmills kristenmills deleted the pending-list-batch branch December 17, 2019 18:25
kristenmills added a commit that referenced this pull request Dec 17, 2019
Forgot to do this in  #2535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants