New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] pending list batch operation and deletion endpoint #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenmills
changed the title
Pending list batch
Add] pending list batch operation endpoint
Dec 17, 2019
kristenmills
changed the title
Add] pending list batch operation endpoint
[Add] pending list batch operation endpoint
Dec 17, 2019
7 tasks
liiight
requested changes
Dec 17, 2019
paranoidi
previously requested changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restful idioms
kristenmills
changed the title
[Add] pending list batch operation endpoint
[Add] pending list batch operation and deletion endpoint
Dec 17, 2019
liiight
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kristenmills
added a commit
that referenced
this pull request
Dec 17, 2019
Forgot to do this in #2535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
I'm adding some bulk operation features to webui (Flexget/webui#54) so this seemed better than making a lot of requests. Eventually I want to just make graphQL or gRPC endpoints for webui to use and these batch operations will be cleaner but that's a later activity.
Detailed changes:
PUT /pending_list/{list_id}/entries/batch
for bulk approving, rejecting pending list entriesDELETE /pending_list/{list_id}/entries/batch
for bulk removing removing pending list entries