New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carthage support #95

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kean
Copy link
Contributor

kean commented Oct 11, 2015

Fixes #93

Changes:

  • Add FLAnimatedImage.xcworkspace; Remove .xcworkspace from gitignore
  • Move FLAnimatedImage/ to the root folder, update podspec accordingly
  • Change framework and demo projects deployment target to iOS 8.0+
  • Update framework and demo projects to recommended settings
  • FLAnimatedImage added to demo project by linking a framework
@bpillon

This comment has been minimized.

Copy link

bpillon commented Nov 16, 2015

Is this possible to merge this ?

@kean kean referenced this pull request Nov 23, 2015

Merged

Rescue Nyan #96

@dzenbot

This comment has been minimized.

Copy link
Contributor

dzenbot commented Nov 28, 2015

👍

@timonus

This comment has been minimized.

Copy link
Contributor

timonus commented Dec 1, 2015

Change framework and demo projects deployment target to iOS 8.0+

Wondering why you did this. I'll likely merge anyways, but doesn't seem necessary to support Carthage. Is it?

@timonus

This comment has been minimized.

Copy link
Contributor

timonus commented Dec 1, 2015

Thanks for this PR! Just merged at 1a6960a.

@timonus timonus closed this Dec 1, 2015

@kean

This comment has been minimized.

Copy link
Contributor

kean commented Dec 2, 2015

Wondering why you did this. I'll likely merge anyways, but doesn't seem necessary to support Carthage. Is it?

Demo now links to FLAnimatedImage.framework (questionable change) and frameworks are only available on iOS 8 or later.

@kean

This comment has been minimized.

Copy link
Contributor

kean commented Dec 2, 2015

I also just spotted that instead of importing headers from the linked framework (#import <FLAnimatedImage/FLAnimatedImage.h>) they are imported directly from "User Header Search Paths", which isn't nice.

@timonus

This comment has been minimized.

Copy link
Contributor

timonus commented Dec 2, 2015

Will update. Also noticed that if you're using Cocoa Lumberjack Logger that linking with the built library doesn't work because a header references non-modular headers. Filed an issue for that here #107.

@timonus

This comment has been minimized.

Copy link
Contributor

timonus commented Dec 3, 2015

@kean planning on having this in a PR sometime to address your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment