From 0c9b570925be8bc043330cfab63e322392e4f069 Mon Sep 17 00:00:00 2001
From: Dawid Witulski <dwitulski@fliplet.com>
Date: Thu, 9 May 2024 14:36:52 +0200
Subject: [PATCH] feat(ID-4358): showing success instead of fail message when
 build completed with errors

---
 interface.html  | 12 +++++++++++-
 js/interface.js |  9 ++++++++-
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/interface.html b/interface.html
index 91607c0..d222d33 100644
--- a/interface.html
+++ b/interface.html
@@ -1908,7 +1908,17 @@ <h4><small>App submission status</small></h4>
               <div class="app-build-name">There was an error building your app</div>
             \{{/if}}
           </td>
-          \{{/if}} \{{#if cancelled}}
+          \{{/if}}
+          \{{#if gracefullyFailed }}
+          <td class="app-build-progress success">
+            <div class="app-build-progress-holder"><i class="fa fa-check-circle"></i> Completed</div>
+          </td>
+          <td class="app-build-details">
+            \{{#if updatedAt}}<span><span class="icon"><i class="fa fa-flag-checkered"></i> Finished on:</span> \{{updatedAt}}</span>\{{/if}}
+            <div class="app-build-name">\{{{message}}}</div>
+          </td>
+          \{{/if}} 
+          \{{#if cancelled}}
           <td class="app-build-progress warning">
             <div class="app-build-progress-holder"><i class="fa fa-ban"></i> Canceled</div>
           </td>
diff --git a/js/interface.js b/js/interface.js
index 16283f4..bc3a8fe 100644
--- a/js/interface.js
+++ b/js/interface.js
@@ -2149,14 +2149,21 @@ function checkSubmissionStatus(origin, iosSubmissions) {
       build.submittedAt = ((submission.status === 'queued' || submission.status === 'submitted') && submission.submittedAt)
         ? moment(submission.submittedAt).format('MMM Do YYYY, h:mm:ss a')
         : '';
-      build[submission.status] = true;
+
       build.fileUrl = appBuild ? removeAuthTokenFromFileUrl(appBuild.url) : '';
       build.versionNumber = _.get(submission, ['data', submissionTypePrefixes[submissionType] + 'versionNumber']);
 
       if (submission.result.message) {
         build.message = submission.result.message;
+        
+        const gracefullyFailedMessage = "The app has been uploaded to the App Store Connect but could not be submitted for review. Please log in on https://appstoreconnect.apple.com/ to finish up the process and submit the app for review.";
+        if (submission.result.message === gracefullyFailedMessage) {
+          submission.status = 'gracefullyFailed';
+        }
       }
 
+      build[submission.status] = true;
+
       if (submission.result.errorCode < 0) {
         build.message = 'There was an error processing your submission. To learn more, go to <a target="_blank" href="https://help.fliplet.com/common-apple-issues/">help.fliplet.com/common-apple-issues</a>.';
       }