From 4434b85413dff4ca2d2f442a64bfaa985795f90c Mon Sep 17 00:00:00 2001
From: Tony Wu <twu@fliplet.com>
Date: Sat, 30 Mar 2019 22:01:37 +0000
Subject: [PATCH 1/3] Moves common code together

---
 js/interface.js | 64 +++++++++++++++----------------------------------
 1 file changed, 19 insertions(+), 45 deletions(-)

diff --git a/js/interface.js b/js/interface.js
index b0a1274..c06a49a 100644
--- a/js/interface.js
+++ b/js/interface.js
@@ -1218,9 +1218,25 @@ function searchCredentials(data) {
     method: 'POST',
     url: 'v1/organizations/' + organizationID + '/credentials/search',
     data: data
-  })
-  .then(function (credentials) {
-    return Promise.resolve(credentials);
+  }).then(function (response) {
+    if (!response) {
+      return;
+    }
+
+    var credentialKey;
+    var submissionsWithCred = _.filter(Object.keys(response), function (o) {
+      return response[o].hasCertificate === true;
+    });
+
+    credentialKey = _.max(submissionsWithCred, function (o) {
+      return response[o].updatedAt;
+    });
+
+    if (!credentialKey) {
+      return;
+    }
+
+    return getCredential(credentialKey);
   });
 }
 
@@ -1269,27 +1285,6 @@ function refreshAppStoreOptions(devEmail, selectedTeamId, selectedTeamName) {
         email: devEmail,
         type: 'apple',
         teamId: selectedTeamId
-      })
-      .then(function (response) {
-        var credentialKey;
-        var submissionsWithCred = _.filter(Object.keys(response), function (o) {
-          return response[o].hasCertificate === true;
-        });
-
-        if (submissionsWithCred) {
-          credentialKey = _.max(submissionsWithCred, function (o) {
-            return response[o].updatedAt;
-          });
-        }
-
-        if (credentialKey) {
-          return getCredential(credentialKey);
-        }
-
-        return;
-      })
-      .catch(function (error) {
-        return;
       });
     })
     .then(function (credential) {
@@ -1355,27 +1350,6 @@ function refreshAppEnterpriseOptions(devEmail, selectedTeamId, selectedTeamName)
         email: devEmail,
         type: 'apple-enterprise',
         teamId: selectedTeamId
-      })
-      .then(function (response) {
-        var credentialKey;
-        var submissionsWithCred = _.filter(Object.keys(response), function (o) {
-          return response[o].hasCertificate === true;
-        });
-
-        if (submissionsWithCred) {
-          credentialKey = _.max(submissionsWithCred, function (o) {
-            return response[o].updatedAt;
-          });
-        }
-
-        if (credentialKey) {
-          return getCredential(credentialKey);
-        }
-
-        return;
-      })
-      .catch(function (error) {
-        return;
       });
     })
     .then(function (credential) {

From 9de3bdae6d03e0ecc9535e99263203a6b00935c0 Mon Sep 17 00:00:00 2001
From: Tony Wu <twu@fliplet.com>
Date: Sat, 30 Mar 2019 22:01:53 +0000
Subject: [PATCH 2/3] Adds error checking to prevent API error

---
 js/interface.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/js/interface.js b/js/interface.js
index c06a49a..78593f2 100644
--- a/js/interface.js
+++ b/js/interface.js
@@ -1439,19 +1439,20 @@ function getCompletedSubmissions(devEmail, teamId, teamName) {
 }
 
 function getCredential(credentialKey) {
+    return Promise.resolve();
+  }
+
   return Fliplet.API.request({
     method: 'GET',
     url: 'v1/organizations/' + organizationID + '/credentials/' + credentialKey
-  })
-  .then(function (credential) {
+  }).then(function (credential) {
     if (!credential || !credential.email) {
       // Valid credential email not found
       return Promise.resolve();
     }
 
     return Promise.resolve(credential);
-  })
-  .catch(function (error) {
+  }).catch(function (error) {
     if (error && error.status === 404) {
       // Credential not found
       return Promise.resolve();

From c8ed170072822d5e8ce72e0287942823e3c70adf Mon Sep 17 00:00:00 2001
From: Tony Wu <twu@fliplet.com>
Date: Sat, 30 Mar 2019 22:02:11 +0000
Subject: [PATCH 3/3] Adds error checking to prevent API error

---
 js/interface.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/js/interface.js b/js/interface.js
index 78593f2..40c7812 100644
--- a/js/interface.js
+++ b/js/interface.js
@@ -1439,6 +1439,7 @@ function getCompletedSubmissions(devEmail, teamId, teamName) {
 }
 
 function getCredential(credentialKey) {
+  if (!credentialKey) {
     return Promise.resolve();
   }