Patch the points below seabed errors and #384#387
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #384, not much else to say, it was just a bug.
Regarding the points below seabed, the rationale was wrong. First, a check on the position set on the config file is already done during the configuration read stage:
https://github.com/FloatingArrayDesign/MoorDyn/blob/master/source/MoorDyn2.cpp#L1154
And that stage just a warning is triggered. On top of that, it might be the case that someone would call
MoorDyn_Init()on an already initialized system. However, if the line was slack, then inner points most probably fall slightly below the seabed (as long as the seabed is a spring).Thus I am just demoting the error to a warning (without throwing an exception)