Minor Node 0.6 upgrades #1

merged 3 commits into from Dec 6, 2011


None yet
2 participants

jhs commented Dec 6, 2011

Hi! I'm get a crash when running the examples in Node v0.6. This is because regular expression objects have changed a bit since 0.4. This request has the fix for that.

I also corrected a warning about the sys module, and changed the package metadata slightly to be a little more explicit.

If you like the changes, would you please merge and bump the version and npm publish? Thanks!

jhs added some commits Dec 6, 2011

Support the different RegEx type in Node 0.6
In Node.js 0.6, `typeof /foo/` returns "function", but
`foo instanceof RegExp` returns `true`. So this change works for both

This comment has been minimized.

Show comment Hide comment

Floby Dec 6, 2011


Looks good to me. Thank you very much =)


Floby commented Dec 6, 2011

Looks good to me. Thank you very much =)

Floby added a commit that referenced this pull request Dec 6, 2011

@Floby Floby merged commit 76f2a70 into Floby:master Dec 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment