New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TranslateWiki #8

Open
FlominatorTM opened this Issue Oct 10, 2015 · 16 comments

Comments

Projects
None yet
3 participants
@FlominatorTM
Owner

FlominatorTM commented Oct 10, 2015

@siebrand Would this be possible?

@siebrand

This comment has been minimized.

Collaborator

siebrand commented Oct 10, 2015

Please look into integrating with https://github.com/Krinkle/intuition. That will make it easy on our side, and standardized on your side.

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Oct 10, 2015

Thanks. Do I get it right, that I have to change the general way my tool retrieves texts with this?

Is there anything from WikiBlame (structure is identical) we could already re-use? Or do I have to start "from scratch"?

@siebrand

This comment has been minimized.

Collaborator

siebrand commented Oct 10, 2015

I don't think you can use anything from WIkiBlame. Please read the README of Intuition. I couldn't find additional documentation, but maybe @Krinkle could point to it, if the README in the repo isn't the best resource.

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Oct 11, 2015

Sorry for being so reluctant. Regarding documentation https://tools.wmflabs.org/intuition/demo/demo1.php looks promising

Will intuition also work with the tool not running on Labs?

How are you able to provide translations for WikiBlame without intuition support? Can't we use the same mechanism also for this tool?

@siebrand

This comment has been minimized.

Collaborator

siebrand commented Oct 11, 2015

WikiBlame was configured as a separate product, in a time we didn't have good frameworks. That's something I don't want any more for a product of a few hundred strings or less. Hence my recommendation (or demand) to use Intuition ;).

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Oct 15, 2015

@siebrand: In the process of integrating Intuition I found the footer mentioned in https://tools.wmflabs.org/intuition/demo/demo5.php which links to labs and apparently won't work with my tool hosted somewhere else.

Now I found the introduction of https://github.com/Krinkle/intuition/wiki/Documentation which states "Intuition is a framework to provide internationalization ( i18n ) for tools hosted at Tool Labs."

Therefore I ask you and @Krinkle again: Will intuition also work with the tool not running on Labs?

FlominatorTM added a commit that referenced this issue Oct 15, 2015

switching to @krinkle/intuition which I installed with composer
converting translations to JSON and deleting the php versions
all needed for TranslationWiki support (issue #8)
no clue if I should have added anything in order to retrieve intuition
@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Oct 16, 2015

@siebrand: I think I included it. Can you or @Krinkle please check if it is ok like this?

What are the next steps?

@Krinkle

This comment has been minimized.

Krinkle commented Oct 19, 2015

@FlominatorTM Thanks, I've updated the documentation at https://github.com/Krinkle/intuition/wiki/Documentation to reflect that Tool Labs is not a requirement. Intuition is a standalone framework that should work fine in any modern PHP environment.

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Oct 25, 2015

@Krinkle Thanks for the update and the new parameter. Is there any documentation on how the translation workflow works? How do I make my strings available? From where to I have to retrieve translations?

@Krinkle

This comment has been minimized.

Krinkle commented Oct 26, 2015

@FlominatorTM You're already using the Intuition framework, and have a messages directory that is compatible with its format.

At this point, follow step 3 and 4 from the migration guide https://github.com/Krinkle/intuition/wiki/Migrate#migration.

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Apr 5, 2016

@Krinkle Step 3 was doable, on step 4 I didn't have a clue what to do with the last four changes of wikimedia/translatewiki@bb2b523

Also it would be really helpful if the migration guide would be a little more verbose on how to send commits to gerrit.

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Apr 10, 2016

@Krinkle Thanks for your comments regarding the footer. Can you please give me some hints here as well?

@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented May 21, 2016

@Krinkle Is there any additional information I can provide you, that might lead to an answer regarding my question from 5th of April?

@Krinkle

This comment has been minimized.

Krinkle commented May 23, 2016

@FlominatorTM Are you looking for help with setting up your Gerrit account? It does require more steps than I'd like.

https://www.mediawiki.org/wiki/Gerrit

  1. Create a Wikimedia Developer account (LDAP) via wikitech.wikimedia.org
  2. Create an SSH key and associate with your account on Gerrit and Wikitech.
  3. Clone a repository with the ssh url (or update the remote of an existing repo).
  4. Either submit your patch via the git-review cli tool, or use plain Git to push for review.
@FlominatorTM

This comment has been minimized.

Owner

FlominatorTM commented Jan 21, 2018

@Krinkle The Gerrit part I got now, thanks. My original problem remains: Your migration guide suggests doing a similiar edit like this one. I was able to adapt all file changes to my code except the last four (starting with groups/Intuition/IntuitionAgg.yaml).

Can you please explain what I'm supposed to change on my code when looking at those last four file diffs?

@Krinkle

This comment has been minimized.

Krinkle commented Jan 22, 2018

@FlominatorTM Can you provide a link to your Gerrit patch so that I can review it and provide feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment