Skip to content
This repository

Stars smaller in the sky than the sun not drawn properly #20

Closed
guygriffiths opened this Issue May 03, 2012 · 3 comments

2 participants

Guy Griffiths James Smith
Guy Griffiths
Collaborator

On Firefox (Ubuntu/Windows 7), the sun is drawn at the same size as the black circle for all planets in our solar system which are further out. This doesn't happen with Chromium (Ubuntu) or Chrome(Windows 7), but it does happen with Opera (Windows 7).

James Smith
Owner
Floppy commented May 10, 2012

Probably some sort of rounding bug...

Guy Griffiths guygriffiths closed this issue from a commit May 10, 2012
Changed code to draw sun so that it doesn't fill the circle (previously
it was filled with emptiness).

fixes #20
04e0c87
Guy Griffiths guygriffiths closed this in 04e0c87 May 10, 2012
Guy Griffiths
Collaborator

That comment prompted me to actually have a look at it. It seems that the sun outline was being filled in (although generally not with anything). Removing the line that fills it seems to have fixed things.

James Smith
Owner
Floppy commented May 10, 2012

Aha, nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.