Skip to content

Fix vMF deterministic sigma-point sampler#2055

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix-vmf-deterministic-sampler
May 16, 2026
Merged

Fix vMF deterministic sigma-point sampler#2055
FlorianPfaff merged 2 commits into
mainfrom
fix-vmf-deterministic-sampler

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • Fix the von Mises-Fisher deterministic sigma-point sampler to use the embedding-dimension mean resultant length a_d(input_dim, kappa).
  • Replace the invalid iv(..., 1) usage in the sampler path by the existing a_d helper and make a_d use the scaled Bessel ratio ive for large-kappa stability.
  • Correct the sigma-point layout so columns are samples in embedding coordinates.
  • Add regression tests for deterministic-sample shape, unit norm, and equal-weight mean-resultant matching.

Notes

I could not run the full repository test suite in this environment because GitHub/network checkout is unavailable here. The changed Python files were syntax-checked locally before pushing through the connector.

@FlorianPfaff FlorianPfaff merged commit edc023a into main May 16, 2026
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant