Fix MegaLinter E402 and invalid parameterized test case causing CI failures#2078
Conversation
… case in test_hypercylindrical_dirac_distribution.py Agent-Logs-Url: https://github.com/FlorianPfaff/PyRecEst/sessions/122939ff-0a32-4535-ba09-d02ee2f0a8c0 Co-authored-by: FlorianPfaff <6773539+FlorianPfaff@users.noreply.github.com>
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
|
@copilot CI/CD and megalinter are still failing, fix it |
- Remove unused prod import in test_abstract_hypersphere_subset_distribution.py - Remove unused KalmanFilter import in test_multi_bernoulli_mixture_tracker.py - Fix mypy override: use HypertoroidalWrappedNormalDistribution type in convolve - Fix pylint E0606: move import inside if-blocks in abstract_hyperspherical_distribution.py - Fix pylint E0102: rename duplicate integrand to integrand_4d in bingham_distribution.py - Add pylint disable for too-many-arguments in abstract_manifold_specific_distribution.py - Add pylint disable for too-many-public-methods in test_von_mises_fisher_distribution.py - Add pylint disable for protected-access in test_lomem_tracker.py and test_multi_bernoulli_mixture_tracker.py - Fix test_kernel_sme_filter.py: use float literals in arange() to avoid 'Long' tensor error Agent-Logs-Url: https://github.com/FlorianPfaff/PyRecEst/sessions/5e0a6233-d90a-48c6-9f78-968780a3cb13 Co-authored-by: FlorianPfaff <6773539+FlorianPfaff@users.noreply.github.com>
Head branch was pushed to by a user without write access
…gle import + pylint disable comments Agent-Logs-Url: https://github.com/FlorianPfaff/PyRecEst/sessions/5e0a6233-d90a-48c6-9f78-968780a3cb13 Co-authored-by: FlorianPfaff <6773539+FlorianPfaff@users.noreply.github.com>
Fixed in commits 738442d and 86b6f5f. The remaining failures were: MegaLinter:
Test failure:
|
|
@copilot CI/CD is still failing, fix |
…aginary check - leopardi_sampler.py: Remove erroneous flip(pts_s_leop, axis=0) and flip(pts_s_half_leop, axis=0); fix plane-reflection sign flip from south[:,0] to south[:,-1] - hyperspherical_sampler.py: Remove redundant flip(grid_eucl, axis=1) in LeopardiSampler and SymmetricLeopardiSampler - abstract_orthogonal_basis_distribution.py: Add imaginary-part assertion in sqrt branch to reject non-real square-root densities Agent-Logs-Url: https://github.com/FlorianPfaff/PyRecEst/sessions/59d958d9-22f4-4cc2-ab56-9f0c8a3ea905 Co-authored-by: FlorianPfaff <6773539+FlorianPfaff@users.noreply.github.com>
Pushed additional fixes in commits up to 5e8186e. MegaLinter is now passing. The test workflow failures are on
Remaining failures (~70) are grouped as: 18 spherical-harmonics complex ValueError, "Always using upper hemisphere" grid/filter AssertionErrors across ~30 tests, plus scatter failures in SO3, sine-skewed, Fourier, circular UKF and linear distribution tests — all pre-existing on |

Two independent CI failures on main: a Ruff E402 lint error in the JAX autodiff test file, and a test collection crash caused by an invalid
PartiallyWrappedNormalDistributioninstantiation at class-body evaluation time.Changes
tests/test_jax_autodiff_backend.py: Add# noqa: E402to thefrom pyrecest._backend.jax import autodiffimport, which legitimately followspytest.importorskip()calls that must execute before any JAX import is attempted.tests/distributions/test_hypercylindrical_dirac_distribution.py: Remove the invalid"1D Plot"parameterized case. It passedarray([1.0])withbound_dim=1, yieldinglin_dim = 1 - 1 = 0, whichAbstractLinBoundedCartProdDistributionrejects at construction time — crashing pytest collection before any test ran.The minimum valid distribution requires
bound_dim ≥ 1andlin_dim ≥ 1; the remaining"2D Plot"and"3D Plot"cases already cover the simplest valid configuration.