Skip to content

Fix evaluation control-flow regressions#2119

Merged
FlorianPfaff merged 11 commits into
mainfrom
codex/fix-evaluation-control-flow-20260521
May 21, 2026
Merged

Fix evaluation control-flow regressions#2119
FlorianPfaff merged 11 commits into
mainfrom
codex/fix-evaluation-control-flow-20260521

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

@FlorianPfaff FlorianPfaff commented May 21, 2026

Summary

  • fix Kalman-filter evaluation prediction with inputs so the process covariance matrix is passed instead of the noise distribution object
  • honor use_likelihood=True in perform_predict_update_cycles by dispatching to likelihood-capable filters
  • make MTT measurement generation accept the per-step/object-array ground-truth representation produced by generate_simulated_scenarios
  • fix the plotting prediction guard to use n_timesteps instead of the nonexistent timesteps key
  • normalize EOT meas_per_step configs to n_meas_at_individual_time_step so checked configs match measurement generation
  • default missing mtt/eot flags in plain custom configs before accessing them
  • add focused regression tests for the evaluation control-flow bugs

Validation

  • Added tests/test_evaluation_control_flow_regressions.py
  • MegaLinter passed on prior PR heads; latest checks are still running/pending after the newest regression commit
  • Package/docs jobs passed on prior PR heads
  • Did not run the full suite locally in this environment

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 28.36s
✅ PYTHON black 5 1 0 0 1.96s
✅ PYTHON isort 5 1 0 0 0.45s
✅ REPOSITORY checkov yes no no 32.71s
✅ REPOSITORY gitleaks yes no no 17.23s
✅ REPOSITORY git_diff yes no no 0.1s
✅ REPOSITORY secretlint yes no no 10.28s
✅ REPOSITORY syft yes no no 2.25s
✅ REPOSITORY trivy-sbom yes no no 3.54s
✅ REPOSITORY trufflehog yes no no 22.75s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 21, 2026 13:58
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

     7 files   -     3       7 suites   - 3   1h 45m 56s ⏱️ - 54m 29s
 1 959 tests +    3   1 948 ✅  -     4     11 💤 +    7  0 ❌ ±0 
14 045 runs   - 5 940  11 574 ✅  - 4 830  2 471 💤  - 1 110  0 ❌ ±0 

Results for commit eb080b4. ± Comparison against base commit d13d78e.

This pull request skips 7 tests.
tests.test_backend_contracts ‑ test_pytorch_to_numpy_detaches_tensors_requiring_grad
tests.test_backend_interface.TestBackendInterface ‑ test_pytorch_choice_without_replacement_returns_unique_values
tests.test_pytorch_backend.TestPytorchBackendCov ‑ test_cov_bias_true_defaults_to_equal_weights
tests.test_pytorch_backend.TestPytorchBackendCov ‑ test_cov_bias_true_normalizes_aweights_without_mutating
tests.test_pytorch_backend.TestPytorchBackendStd ‑ test_std_accepts_keepdims_and_dtype
tests.test_pytorch_backend.TestPytorchBackendStd ‑ test_std_accepts_numpy_style_axis_and_ddof
tests.test_pytorch_backend.TestPytorchBackendStd ‑ test_std_rejects_conflicting_ddof_and_correction

@FlorianPfaff FlorianPfaff merged commit e7105e2 into main May 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant