Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Pages #25

Closed
wants to merge 5 commits into from
Closed

CSS Pages #25

wants to merge 5 commits into from

Conversation

acockburn
Copy link
Contributor

Additional code to allow multiple dashboards to be loaded in a single page with CSS transitions between them.

@FlorianZ
Copy link
Owner

Pulled into the development branch.

It looks like my dashboards are no longer horizontally aligned on desktop browsers, since this change. Any ideas what might have broken that?

@FlorianZ FlorianZ closed this Nov 26, 2014
@acockburn
Copy link
Contributor Author

I figured it out if I understand what you meant - there was some code in the dashboard (the Javascript at the top) that overrode the tile aspect ratio and number of columns as set in application.coffee (I use an IPad so have different values to you). I took that out, and also figured out that the call to initialize the CSS stuff could also be moved to application.coffee which makes the dashboard code a lot cleaner.

I have pushed the changes to my repository - do I need to create a new pull request for you to grab them? (still figuring out Git ...)

@FlorianZ
Copy link
Owner

I already integrated the changes that way: e29522e

None of that javascript code in the .erb file is still in there.

My guess is that the flying widgets script adds some styling to the gridster container, which makes it no longer be centered. It's not a big deal. I will take a look when I get a chance.

@acockburn
Copy link
Contributor Author

I took a quick look and the offending line is 407 in cycleDashboards.coffee:

    # Set all dashboards to position: absolute so they stack one on top of the other
    $(dashboard).css "position": "absolute"

I tried changing it to "static" and it restored the centered behavior, but the transitions were a little clunkier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants