Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider LiquidCore instead of Node #811

Closed
tomholub opened this issue Jan 28, 2020 · 4 comments
Closed

consider LiquidCore instead of Node #811

tomholub opened this issue Jan 28, 2020 · 4 comments
Assignees
Milestone

Comments

@tomholub
Copy link
Collaborator

I will experiment with using LiquidCore instead of full-fledged Nodejs instance.

On iOS we use something very similar to that, and it works well + is very light weight.

https://github.com/LiquidPlayer/LiquidCore/wiki/LiquidCore-as-a-Raw-JavaScript-engine-for-Android-(v.-0.7.0-)

Another advantage will be that we would not need to create RSA certs when app starts, and we would not need to communicate over https and so on. Quite similar to what we have done before with J2V8, but hopefully it will work better.

This will almost certainly resolve #753

@tomholub tomholub added this to the 0.9.8: Core updates milestone Jan 28, 2020
@tomholub tomholub self-assigned this Jan 28, 2020
@tomholub
Copy link
Collaborator Author

Also it will reduce app footprint, no longer need to include node binaries for all platforms.

@DenBond7
Copy link
Collaborator

@tomholub Very interesting... need to investigate that. Basically, the current realization works much better than j2v8. But of course, we have many places which we can improve.

@tomholub
Copy link
Collaborator Author

They designed it to be very similar to JavaScriptCore which we use on iOS:

https://github.com/FlowCrypt/flowcrypt-ios/blob/master/FlowCrypt/Core/Core.swift#L84

@DenBond7 DenBond7 modified the milestones: 0.9.8: Core updates, 0.9.9 Feb 28, 2020
@tomholub tomholub modified the milestones: 0.9.9, core Mar 16, 2020
@tomholub
Copy link
Collaborator Author

superseded by #976

@DenBond7 DenBond7 modified the milestones: core, Discussion Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants