Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to send outgoing message as pgp/mime #1620

Closed
tomholub opened this issue Apr 4, 2019 · 5 comments · Fixed by #2186
Closed

option to send outgoing message as pgp/mime #1620

tomholub opened this issue Apr 4, 2019 · 5 comments · Fixed by #2186
Assignees
@tomholub
Labels
compatibility
Milestone
7.1.0: Experiment...

Comments

@tomholub
Copy link
Collaborator

tomholub commented Apr 4, 2019 •
edited

#1621

The settings of using rich text or poor text should be sticky.

related #921
@tomholub tomholub added this to the First priority milestone Apr 4, 2019
@tomholub tomholub mentioned this issue Apr 4, 2019
Closed
@tomholub tomholub self-assigned this Jun 17, 2019
@tomholub
Copy link
Collaborator Author

This is a fairly important compatibility issue, see https://flowcrypt.com/docs/technical/openpgp-compatibility.html

@tomholub tomholub mentioned this issue Jul 17, 2019
Closed
@tomholub
Copy link
Collaborator Author

related: wysiwyg editor #1630

@tomholub tomholub mentioned this issue Jul 24, 2019
Closed
@tomholub
Copy link
Collaborator Author

#1861 is waiting for this

@tomholub
Copy link
Collaborator Author

Since Mailvelope does not support reading PGP/MIME emails that are sent as an attachment (mailvelope/mailvelope#41), we will have to still allow users to switch it back to what we could call "Compatibility mode" or something like that, as one of the options in the send button popover:

image

Maybe like this:

image

This was referenced Nov 19, 2019
Closed
Merged
@tomholub tomholub changed the title send outgoing message as pgp/mime by default option to send outgoing message as pgp/mime Nov 20, 2019
@tomholub
Copy link
Collaborator Author

Switched to toggles for simplicity

image

@tomholub tomholub modified the milestones: First priority, 7.1.0 Nov 20, 2019
@tomholub tomholub mentioned this issue Nov 20, 2019
Closed
tomholub pushed a commit that referenced this issue Nov 20, 2019
issue #2184 #1620 #921 #1522 refactor + experimental pgp/mime (#2186)
2f77711 
* created GeneralMailFormatter

* split formatters into files

* finalizeSendableMsg separate from doSendMsg

* separate ComposerPwdOrPubkeyContainer

* separate ComposerWindowSize

* separate ComposerSender

* separate ComposerAtts

* separate ComposerErrs

* separate ComposerTextInput

* move more to composer-errs

* separate ComposerRender

* rename composer modules

* rename render

* combine composer errs files

* renamed composer modules

* refactored formatters, preparing for richText

* allow rich text for plain messages

* pgp/mime encrypted msg

* fix css

* detached signatures

* fixed encrypted pgp/mime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomholub tomholub

Labels
compatibility
Projects
None yet
Milestone
7.1.0: Experimental PGP/MIME compose
Development

Successfully merging a pull request may close this issue.

refactor formatters + composer + experimental pgp/mime FlowCrypt/flowcrypt-browser
1 participant
@tomholub