Added test for updating non-first private key #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomholub
reviewed
Jan 8, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Code looks good with a small update
| ava.default('settings - my key page - update non-first private key', testWithBrowser(undefined, async (t, browser) => { | ||
| const acctEmail = 'flowcrypt.test.key.multiple@gmail.com'; | ||
| const settingsPage1 = await BrowserRecipe.openSettingsLoginApprove(t, browser, acctEmail); | ||
| await SetupPageRecipe.manualEnter(settingsPage1, 'unused', { |
Collaborator
There was a problem hiding this comment.
Eventually we can refactor this unused away in this issue: #3246
tomholub
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3109