Skip to content

Conversation

@rrrooommmaaa
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa commented Jan 4, 2022

This PR adds a red badge when renderErr is called.
I figured, in the case when a signed-only message parse error occurs, it'd be more appropriate to display "parse error" than "decrypt error"

close #4211 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomholub tomholub merged commit 4fe1a94 into master Jan 13, 2022
@tomholub tomholub deleted the issue-4211-error-badge branch January 13, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a red badge for decrypt errors

3 participants