Skip to content

Conversation

@martgil
Copy link
Collaborator

@martgil martgil commented Jul 17, 2025

This PR updates the OpenPGP.js configuration in the FlowCrypt browser extension by defining a set of algorithms to be rejected.

close #6046


Tests (delete all except exactly one):
-No new test needed. A test already exists, but the actual error handling has been updated to align with the recent change.


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner July 17, 2025 06:02
@martgil martgil marked this pull request as draft July 17, 2025 06:32
@martgil martgil marked this pull request as ready for review July 17, 2025 10:16
@martgil

This comment was marked as outdated.

@martgil martgil requested a review from sosnovsky July 18, 2025 06:07
@martgil
Copy link
Collaborator Author

martgil commented Jul 18, 2025

@sosnovsky - It's all good now. thanks!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit 5e1882c into master Jul 18, 2025
12 checks passed
@sosnovsky sosnovsky deleted the issue-6046-update-opgp-configs branch July 18, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define rejectHashAlgorithms in openpgp configuration

3 participants