From 91a1f531a96cff3f772412aa3f8705122f0a2898 Mon Sep 17 00:00:00 2001 From: Ioan Moldovan Date: Tue, 9 Sep 2025 09:55:09 -0300 Subject: [PATCH 1/5] fix: gmail chat test --- test/source/tests/tooling/browser-recipe.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/source/tests/tooling/browser-recipe.ts b/test/source/tests/tooling/browser-recipe.ts index abab2c89546..5434d8662cb 100644 --- a/test/source/tests/tooling/browser-recipe.ts +++ b/test/source/tests/tooling/browser-recipe.ts @@ -75,7 +75,7 @@ export class BrowserRecipe { // close announcement about updated UI await googleChatPage.waitAndClick('.fKz7Od', { delay: 1 }); } - await googleChatPage.waitAny(['a.gb_6d', 'a.gb_Fc', 'a.gb_9d', 'a.gb_7d']); // Google hangout logo + await googleChatPage.waitAny(['a.gb_6d', 'a.gb_Fc', 'a.gb_9d', 'a.gb_7d', 'a.gb_ce', 'a.gb_Sc']); // Google hangout logo return googleChatPage; }; From 35769d5f9ab1c3cfcb6a8605ce5da851d01af285 Mon Sep 17 00:00:00 2001 From: Ioan Moldovan Date: Wed, 10 Sep 2025 02:42:53 -0400 Subject: [PATCH 2/5] fix: test --- test/source/tests/tooling/browser-recipe.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/source/tests/tooling/browser-recipe.ts b/test/source/tests/tooling/browser-recipe.ts index 5434d8662cb..b42eaaa5457 100644 --- a/test/source/tests/tooling/browser-recipe.ts +++ b/test/source/tests/tooling/browser-recipe.ts @@ -71,11 +71,12 @@ export class BrowserRecipe { public static openGoogleChatPage = async (t: AvaContext, browser: BrowserHandle, googleLoginIndex = 0) => { const googleChatPage = await browser.newPage(t, TestUrls.googleChat(googleLoginIndex)); await Util.sleep(5); - if (await googleChatPage.isElementPresent('.fKz7Od')) { + const chatFrame = await googleChatPage.getFrame(['https://chat.google.com/u/0/mole/world']); + if (await chatFrame.isElementPresent('.fKz7Od')) { // close announcement about updated UI - await googleChatPage.waitAndClick('.fKz7Od', { delay: 1 }); + await chatFrame.waitAndClick('.fKz7Od', { delay: 1 }); } - await googleChatPage.waitAny(['a.gb_6d', 'a.gb_Fc', 'a.gb_9d', 'a.gb_7d', 'a.gb_ce', 'a.gb_Sc']); // Google hangout logo + await chatFrame.waitAny(['a.gb_6d', 'a.gb_Fc', 'a.gb_9d', 'a.gb_7d', 'a.gb_ce', 'a.gb_Sc']); // Google hangout logo return googleChatPage; }; From 4ac3cf2d1ad4578cf8ba6c67e432b3a54f766377 Mon Sep 17 00:00:00 2001 From: Ioan Moldovan Date: Wed, 10 Sep 2025 04:29:54 -0400 Subject: [PATCH 3/5] fix: test --- test/source/tests/gmail.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/test/source/tests/gmail.ts b/test/source/tests/gmail.ts index 3b0c1ab723e..026c7159d90 100644 --- a/test/source/tests/gmail.ts +++ b/test/source/tests/gmail.ts @@ -97,8 +97,11 @@ export const defineGmailTests = (testVariant: TestVariant, testWithBrowser: Test expect(urls.length).to.equal(0); }; - const openGmailPage = async (t: AvaContext, browser: BrowserHandle): Promise => { - const url = TestUrls.gmail(0); + const openGmailPage = async (t: AvaContext, browser: BrowserHandle, path?: string): Promise => { + let url = TestUrls.gmail(0); + if (path) { + url = TestUrls.gmail(0, path, 'inbox'); + } return await browser.newPage(t, url); }; @@ -401,8 +404,7 @@ export const defineGmailTests = (testVariant: TestVariant, testWithBrowser: Test 'mail.google.com - plain reply to encrypted and signed messages', testWithBrowser(async (t, browser) => { await BrowserRecipe.setUpCommonAcct(t, browser, 'ci.tests.gmail'); - const gmailPage = await openGmailPage(t, browser); - await gotoGmailPage(gmailPage, '/FMfcgzGkbDRNgcQxLmkhBCKVSFwkfdvV'); // plain convo + const gmailPage = await openGmailPage(t, browser, '/FMfcgzGkbDRNgcQxLmkhBCKVSFwkfdvV'); // plain convo await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 1 }); await gotoGmailPage(gmailPage, '/181d226b4e69f172'); // go to encrypted convo await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 1 }); @@ -578,14 +580,13 @@ export const defineGmailTests = (testVariant: TestVariant, testWithBrowser: Test ); // convo-sensitive, draft-sensitive test - test.serial( + test.only( 'mail.google.com - plain reply draft', testWithBrowser( async (t, browser) => { await BrowserRecipe.setUpCommonAcct(t, browser, 'ci.tests.gmail'); - const gmailPage = await openGmailPage(t, browser); const threadId = '181d226b4e69f172'; // 1st message -- thread id - await gotoGmailPage(gmailPage, `/${threadId}`); // go to encrypted convo + const gmailPage = await openGmailPage(t, browser, `/${threadId}`); await GmailPageRecipe.trimConvo(gmailPage, threadId); await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 5 }); t.timeout(minutes(2)); // extend ava's timeout From 6e0d47300ae1ac613505387bcb29f3454d66c44e Mon Sep 17 00:00:00 2001 From: Ioan Moldovan Date: Wed, 10 Sep 2025 04:46:21 -0400 Subject: [PATCH 4/5] fix: only --- test/source/tests/gmail.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/source/tests/gmail.ts b/test/source/tests/gmail.ts index 026c7159d90..154cb266701 100644 --- a/test/source/tests/gmail.ts +++ b/test/source/tests/gmail.ts @@ -580,7 +580,7 @@ export const defineGmailTests = (testVariant: TestVariant, testWithBrowser: Test ); // convo-sensitive, draft-sensitive test - test.only( + test.serial( 'mail.google.com - plain reply draft', testWithBrowser( async (t, browser) => { From 6a9262002238fe214890ce9765731f81b1537608 Mon Sep 17 00:00:00 2001 From: Ioan Moldovan Date: Wed, 10 Sep 2025 19:44:05 -0400 Subject: [PATCH 5/5] fix: test --- test/source/tests/gmail.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/source/tests/gmail.ts b/test/source/tests/gmail.ts index 154cb266701..070308c19a7 100644 --- a/test/source/tests/gmail.ts +++ b/test/source/tests/gmail.ts @@ -404,9 +404,10 @@ export const defineGmailTests = (testVariant: TestVariant, testWithBrowser: Test 'mail.google.com - plain reply to encrypted and signed messages', testWithBrowser(async (t, browser) => { await BrowserRecipe.setUpCommonAcct(t, browser, 'ci.tests.gmail'); - const gmailPage = await openGmailPage(t, browser, '/FMfcgzGkbDRNgcQxLmkhBCKVSFwkfdvV'); // plain convo + let gmailPage = await openGmailPage(t, browser, '/FMfcgzGkbDRNgcQxLmkhBCKVSFwkfdvV'); // plain convo await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 1 }); - await gotoGmailPage(gmailPage, '/181d226b4e69f172'); // go to encrypted convo + await gmailPage.close(); + gmailPage = await openGmailPage(t, browser, '/181d226b4e69f172'); // go to encrypted convo await gmailPage.waitAndClick('[data-tooltip="Reply"]', { delay: 1 }); await gmailPage.waitTillGone('.reply_message'); await gmailPage.waitAll('[data-tooltip^="Send"]'); // The Send button from the Standard reply box