Skip to content

#6236 Improve URL paths handling#6237

Merged
sosnovsky merged 2 commits into
masterfrom
6236-improve-url-paths-handling
Jun 8, 2026
Merged

#6236 Improve URL paths handling#6237
sosnovsky merged 2 commits into
masterfrom
6236-improve-url-paths-handling

Conversation

@sosnovsky

Copy link
Copy Markdown
Collaborator

This PR adds encodeURIComponent for dynamic path segments + uses URLSearchParams and Url.create for query strings

close #6236


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from martgil June 5, 2026 19:24
@sosnovsky sosnovsky marked this pull request as ready for review June 5, 2026 19:24

@martgil martgil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the fix!

@sosnovsky sosnovsky merged commit c186d4b into master Jun 8, 2026
12 checks passed
@sosnovsky sosnovsky deleted the 6236-improve-url-paths-handling branch June 8, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encode dynamic URL paths and query parameters

2 participants