fix: fix responsiveness on mobile resolutions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-godoy
requested changes
Jan 25, 2024
Member
javier-godoy
left a comment
javier-godoy
left a comment
There was a problem hiding this comment.
Also, note that commits of type style: addresses changes such as formatting. Fixes to styling issues must have type fix:
| buttonsLayout.add(new DayOfWeekButton(DayOfWeek.SATURDAY, "S")); | ||
|
|
||
| buttonsLayout.setWidthFull(); | ||
| buttonsLayout.setJustifyContentMode(JustifyContentMode.CENTER); |
Member
There was a problem hiding this comment.
Style in CSS file (otherwise it cannot be overriden)
| */ | ||
| public DayOfWeekSelector() { | ||
| getStyle().set("padding", "var(--lumo-space-m)"); | ||
| getStyle().set("width", "100%"); |
Member
There was a problem hiding this comment.
Replace with setWidthFull();
Valenreynoso17
force-pushed
the
fix-responsiveness
branch
from
e8e2ab2 to
4fc14b4
Compare
javier-godoy
changed the title
Member
|
Close #3 |
Valenreynoso17
force-pushed
the
fix-responsiveness
branch
from
4fc14b4 to
1ebc4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will solve the following issue in ActivityLog: Fix responsiveness in TimestampFilterDialog #93