Skip to content

Conversation

@AidanTilgner
Copy link
Contributor

A couple of considerations here:

    1. --no-sandbox means that puppeteer and chromium won't execute in a sandbox. This could theoretically have security implications, but since this is in a docker image I doubt it will matter. Maybe something to discuss further.
    1. I'm not entirely sure the context around ENV PUPPETEER_SKIP_DOWNLOAD=true in the Dockerfile, although based on this pr it seems that the default install script was causing an error. I'm not seeing this error during build time here, and my thinking is through the Dockerfile there's more control anyway.

@AidanTilgner
Copy link
Contributor Author

Also for consideration, the headless: "new" thing, I added to silence the current warning about the default headless mode switching in the future.

@HenryHengZJ HenryHengZJ requested a review from chungyau97 July 7, 2023 21:43
@chungyau97 chungyau97 requested a review from HenryHengZJ July 8, 2023 07:42
@HenryHengZJ
Copy link
Contributor

@chungyau97 have you tried root Dockerfile, not the one inside docker folder

@chungyau97
Copy link
Contributor

chungyau97 commented Jul 8, 2023

@chungyau97 have you tried root Dockerfile, not the one inside docker folder

@HenryHengZJ I copy the changes and use it in the root folder
I test it here in my fork
image

@chungyau97
Copy link
Contributor

chungyau97 commented Jul 8, 2023

Results:
Docker Folder
Before
image
After
Not able to test because, RUN npm install -g flowise is not using the changes of this puppeteer

Render
Before
image
After
image

@chungyau97 chungyau97 merged commit 6a7e378 into FlowiseAI:main Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants