fix: docker should install chromium and puppeteer should be no sandbox #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




A couple of considerations here:
--no-sandboxmeans that puppeteer and chromium won't execute in a sandbox. This could theoretically have security implications, but since this is in a docker image I doubt it will matter. Maybe something to discuss further.ENV PUPPETEER_SKIP_DOWNLOAD=truein the Dockerfile, although based on this pr it seems that the default install script was causing an error. I'm not seeing this error during build time here, and my thinking is through the Dockerfile there's more control anyway.