Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore null IMEI/IMSI in QA checks #6621

Merged
merged 4 commits into from
May 23, 2024
Merged

Ignore null IMEI/IMSI in QA checks #6621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bcee96
Ignore null IMEI/IMSI in QA checks
jc-harrison May 22, 2024
ab24d92
Update CHANGELOG.md
jc-harrison May 22, 2024
800c978
Merge branch 'master' into fix-qa-checks
jc-harrison May 23, 2024
61d299d
Merge branch 'master' into fix-qa-checks
mergify[bot] May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed
- Queries that have multiple of the same subquery with different parameters no longer cause duplicate scopes in tokens. [#6580](https://github.com/Flowminder/FlowKit/issues/6580)
- FlowETL QA checks `count_imeis`, `count_imsis`, `max_msisdns_per_imei` and `max_msisdns_per_imsi` now only count non-null IMEIs/IMSIs. [#6619](https://github.com/Flowminder/FlowKit/issues/6619)

### Removed

Expand Down
1 change: 1 addition & 0 deletions flowetl/flowetl/flowetl/qa_checks/qa_checks/count_imeis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ FROM (
imei
FROM
{{ final_table }}
WHERE imei IS NOT NULL
GROUP BY
imei) _
1 change: 1 addition & 0 deletions flowetl/flowetl/flowetl/qa_checks/qa_checks/count_imsis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ FROM (
imsi
FROM
{{ final_table }}
WHERE imsi IS NOT NULL
GROUP BY
imsi) _
1 change: 1 addition & 0 deletions flowetl/flowetl/flowetl/qa_checks/qa_checks/max_msisdns_per_imei.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ FROM (
msisdn
FROM
{{ final_table }}
WHERE imei IS NOT NULL
GROUP BY
imei,
msisdn) _
Expand Down
1 change: 1 addition & 0 deletions flowetl/flowetl/flowetl/qa_checks/qa_checks/max_msisdns_per_imsi.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ FROM (
msisdn
FROM
{{ final_table }}
WHERE imsi IS NOT NULL
GROUP BY
imsi,
msisdn) _
Expand Down