Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public wrapper function for free() #562

Merged
merged 1 commit into from Sep 24, 2019
Merged

Add a public wrapper function for free() #562

merged 1 commit into from Sep 24, 2019

Conversation

derselbst
Copy link
Member

to allow proper deallocation for programming languages other than C/C++.

to allow proper deallocation for programming languages other than C.
@derselbst derselbst added this to the 2.0-post milestone Sep 23, 2019
@jjceresa
Copy link
Collaborator

May be fluid_free() could be renamed fluid_free_mem(), to avoid confusion with other delete_fluid_**() function ?

@derselbst
Copy link
Member Author

to avoid confusion with other delete_fluid_**() function ?

That's why I've put an explicit comment for that to fluid_free(). I would state that fluid_free_mem() only makes naming unnecessarily complicated.

@jjceresa
Copy link
Collaborator

Oh yes, the comment (i had not read before!) is clear, so fluid_free() name is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants