New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces feature support #627

Closed
NamelessCoder opened this Issue Aug 2, 2014 · 10 comments

Comments

Projects
None yet
6 participants
@NamelessCoder
Copy link
Member

NamelessCoder commented Aug 2, 2014

This issue is created to keep track of current issues in Workspaces support. To have issues added, write a comment describing the problem(s) you are facing. A checkmark means the specific feature works:

Frontend

  • Page content output of top-level elements (content elements not inside Flux containers) on pages both published (having live workspace PID) and unpublished (only existing as placeholders).
  • Page content output when viewing published live workspace.
  • Page content record attributes correctly rendered when previewing unpublished changes.
  • Output of nested content elements in Flux containers due to incorrectly updated placeholder record values (see backend issues).
  • Output of page menus does not include unpublished pages.

Backend

  • Editing top-level page content in unpublished workspace.
  • Creating top-level page content in unpublished workspace.
  • Editing child content elements in unpublished workspace.
  • Creating child content elements in unpublished workspace.
  • Deleting content elements in unpublished workspace.
  • Creating copies of pages when parent page is unpublished. Note: core JS bug; immediate title after copying a record is identical to source record regardless of "prependOnCopy" settings; this bug is not the responsibility of FluidTYPO3.
  • Output of nested content elements not working. Cause: placeholder record values are not updated with correct tx_flux_parent value; workspace target record is updated with correct value. When modifying the placeholder record in database, output is restored.
  • Error observed while saving new page records through page tree in an unpublished workspace; cause unclear - potential core bug related to usage of MySQL 5.6 with incomplete updates (specific error: storage_pid record value contains a non-integer value when saved to SQL). Effect: placeholder page record and target workspace version records are duplicated, but neither can be edited. Both can, however, be previewed in frontend. Cause found: SQL strict mode on, TYPO3 core not casting missing field values.
  • Error observed while renaming pages through page tree in an unpublished workspace, likely caused by same problem as previous error. Cause found: SQL strict mode on, TYPO3 core not casting missing field values.
  • Error saving changes to pages table records, same error as above. Cause found: SQL strict mode on, TYPO3 core not casting missing field values.
  • Endless loop when user opens edit view of page records in the same workspace which has pending changes to those records. To reproduce: switch to workspace, make change to page, attempt to edit page.
  • Pages which only exist in an unpublished workspace do not inherit page template selections from parent pages.
  • Sorting of nested child content elements: sorted element does not get sorted correctly both when using sorting arrows and drag-n-drop. Suspected cause is the "resorting" method on TCEMain. Fixed by 48e5825.
  • New content elements on new pages which only exist in a workspace are doubled when moved - does not appear to be in effect when moving content on pages which have a live version. The correct child content is displayed after workspace is published to LIVE. This indicates that the problem seems to be caused by the content selection query in the grid widget with the symptom that the initial placeholder record is included in the list also when a draft exists - the correct expected behavior would be to not show the placeholder (and possibly also to limit to only show the most recent draft of each record - this has to be investigated). It also has to be investigated how/if this effect has any relevance when making subsequent drafts of elements which are container elements - should placeholders be updated as well? Are they already being updated by cascading TCA? Is there a difference whether the container is itself a child of another element or is a root content element?
  • Copying a LIVE element from one Flux column and pasting into another Flux column of the same element, does not adjust the tx_flux_column value when the copy is created. Using this now incorrectly placed copy as relative element for another paste or drag-drop operation makes the pasted/dragged record lose relationship to parent. Moving the incorrectly placed copied element works.
  • Drag-n-drop of content elements which only exist in a workspace, works. Doing the same with a content element that is currently in the live workspace - fails (element reverts back to original position).
@Outdoorsman

This comment has been minimized.

Copy link
Contributor

Outdoorsman commented Sep 1, 2014

Feedback on the doubled content issue
I originally got these issues in the non-LIVE workspace on a page that first existed in LIVE workspace... it wasn't a new page.

@NamelessCoder

This comment has been minimized.

Copy link
Member

NamelessCoder commented Sep 1, 2014

@Outdoorsman do you remember if you had made changes to that page in the workspace? When I was testing this would not happen un "un-orange" (wee, words) pages.

NamelessCoder added a commit that referenced this issue Sep 2, 2014

[BUGFIX] Improve integration of workspaces child content
This patch fixes a few issues with respecting the record selection and display conditioning done in PageLayoutView, as implemented in Flux's content area renderer which selects the content elements to be displayed.

Most importantly this fixes the incorrect display of move and delete placeholders, correctly filtering deleted records out and using the placeholder's position values when placeholder is a move placeholder.

References: #627
@NamelessCoder

This comment has been minimized.

Copy link
Member

NamelessCoder commented Sep 2, 2014

Problem with placeholder records appears fixed now.

@hkarvasonis

This comment has been minimized.

Copy link

hkarvasonis commented Sep 9, 2014

Hi,

i have the double content issue on an already published page.
If i have a page with 2 elements and move an element below the other inside the workspace, then the moved element appears twice on the frontend.
I tested that with the latest version and i can still replicate that.

Can you tell me at which direction i could look on fixing that or is it something known that you are already working on?

Thanks,
Hercules.

@xmaxw

This comment has been minimized.

Copy link

xmaxw commented Nov 29, 2014

Hi,

I have the same issue as #603, when using workspaces.

I cannot edit a content element which is inside a flux container by clicking on pencil icon. I have this error : "Sorry, you didn't have proper permissions to perform this change". However, it works by using context menu (click on icon which is on the left side of element header) or by using the list mode.
The problem appears for elements which only exist in a workspace.
(Tested on TYPO3 6.2.6 / flux 7.1.2 / fluidcontent 4.1.1)

Thanks,
Max

@xmaxw

This comment has been minimized.

Copy link

xmaxw commented Dec 1, 2014

Another issue : Element disappears after using Drag&Drop in Workspace and publishing to LIVE
Steps to reproduce this bug :

  • In a Non-live Workspace (existing page), create a new content element (like Text Element) outside of the FCE
  • Move this element inside an existing FCE by using Drag&Drop
  • On preview, element is displayed correctly
  • Publish the changes to the LIVE workspace
  • The content element disappears (-> invisible). In database, element is present but tx_flux_column & tx_flux_parent values are lost.

(TYPO3 6.2.6 / flux 7.1.2 / fluidcontent 4.1.1)

@hsouiba

This comment has been minimized.

Copy link

hsouiba commented Dec 9, 2014

Hi,

Actually I have the same as Max "Element disappears after using Drag&Drop in Workspace and publishing to LIVE" on same TYPO3 version. Any idea please ?

@xmaxw

This comment has been minimized.

Copy link

xmaxw commented Dec 18, 2014

About pencil icon issue, if I remove the following line in ContentAreaViewHelper (line 131), it works fine :
$record = $this->getWorkspaceVersionOfRecordOrRecordItself($record);
Maybe we don't need workspace version of record at this point ?

@hsouiba

This comment has been minimized.

Copy link

hsouiba commented Dec 18, 2014

Hi xmaxw, what about the second issue you encountered (drag & drop) do you have any solution ?

@NamelessCoder

This comment has been minimized.

Copy link
Member

NamelessCoder commented Aug 8, 2015

Closing bulk issue. Remaining issues may now be reported individually - very few should remain. I'd like to take this opportunity to thank everyone who helped by reporting, testing, re-testing and contributing fixes to get us where we are now in terms of workspaces support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment