Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple conditions in if.condition.extend doesn't work #398

Closed
patrickroquin opened this issue Nov 20, 2013 · 4 comments
Closed

[BUG] Multiple conditions in if.condition.extend doesn't work #398

patrickroquin opened this issue Nov 20, 2013 · 4 comments

Comments

@patrickroquin
Copy link

A multiple condition in if.condition.extend doesn't work in the branch master.

Example:

<v:if.condition>
    <v:if.condition.extend>
        1 == 1 && 2 == 2
    </v:if.condition.extend>
    <f:then>
        OUTPUT TRUE
    </f:then>
    <f:else>
        OUTPUT FALSE
    </f:else>
</v:if.condition>

Returns 'OUTPUT FALSE'

@danilobuerger
Copy link

i can confirm this. @bjo3rnf werent your working on that?

@bjo3rnf
Copy link
Contributor

bjo3rnf commented Nov 20, 2013

Hi @patrickroquin and @danilobuerger,

yes, the condition.extend viewhelper is all broken. I tried to fix it but to no avail yet. Parsing of the conditions is somewhat incorrect and tbh I didn't quite understand its logic yet so if someone else (smarter than me) wants to take a look at it go right ahead ;)

Cheers
Björn

@danilobuerger
Copy link

Also affected #376 and #318

@danilobuerger
Copy link

Hello @patrickroquin

we had a discussion about this and decided to drop v:if.condition and v:if.condition.extend. They are now marked as deprecated.

We replaced them with a much better view helper called v:if. It does have a different syntax explained here: #401

Please try it out.

Since everybody needing v:if.condition.extend should move to v:if we won't be fixing v:if.condition.extend. As such, i will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants