Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libnetcdff configure #160

Merged
merged 2 commits into from Jun 30, 2017
Merged

Fix libnetcdff configure #160

merged 2 commits into from Jun 30, 2017

Conversation

jrper
Copy link
Contributor

@jrper jrper commented Jun 26, 2017

This changeset attempts to improve the behaviour of the configure script in searching for the netcdf Fortan interface library (libnetcdff). Without these changes, there are issues with the shared library build.

This changeset attempts to improve the behaviour of the configure script in searching for the netcdf Fortan interface library (libnetcdff). Without these changes, there are issues with the shared library build.
@jrper jrper requested a review from tmbgreaves June 26, 2017 14:16
@stephankramer
Copy link
Contributor

Should you commit configure as well?

@jrper
Copy link
Contributor Author

jrper commented Jun 26, 2017

... oops.

@tmbgreaves
Copy link
Contributor

That looks entirely sane to me; very happy for it to go in assuming buildbot is happy:

http://buildbot.ese.ic.ac.uk:8080/builders/fix_netcdff_configure

@jrper
Copy link
Contributor Author

jrper commented Jun 30, 2017

Buildbot matches master (the failure is one Tim has fixed elsewhere), so I'm merging this.

@jrper jrper closed this Jun 30, 2017
@jrper jrper reopened this Jun 30, 2017
@jrper jrper merged commit 26e484e into master Jun 30, 2017
@jrper jrper deleted the fix_netcdff_configure branch June 30, 2017 16:06
jrper added a commit that referenced this pull request Jul 28, 2017
* Fix libnetcdff configure

This changeset attempts to improve the behaviour of the configure script in searching for the netcdf Fortan interface library (libnetcdff). Without these changes, there are issues with the shared library build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants