Allow users enter their card expiry date easily; provide better UX #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. Will test and merge soon. Thanks |
IEnoobong
reviewed
Mar 6, 2018
| public void afterTextChanged(Editable editable) { | ||
| String input = editable.toString(); | ||
| SimpleDateFormat simpleDateFormat = new SimpleDateFormat("MM/yy"); | ||
| Calendar calendar = Calendar.getInstance(); |
Contributor
Author
There was a problem hiding this comment.
Oh...true.
I will fix that. Thanks
Contributor
Author
There was a problem hiding this comment.
It's updated now.
biodunalfet
reviewed
Mar 7, 2018
| @Override | ||
| public void afterTextChanged(Editable editable) { | ||
| String input = editable.toString(); | ||
| SimpleDateFormat simpleDateFormat = new SimpleDateFormat("MM/yy"); |
Contributor
There was a problem hiding this comment.
You're creating an instance of simpleDateFormat each time the text changes which is expensive. Try to create it once in the ExpiryWatcher()'s constructor and use that instance in line 860 instead just like you did for your calendar variable. Neat work by the way
Contributor
Author
There was a problem hiding this comment.
Oh true. Correcting that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering what most users have gotten used to, allowing them to enter their expiry date in text will provide a better user experience.